Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(480114)

Issue 916: Remove unused parameter from fetch_and_process_video in encoder_example.

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 3 months ago by tdaede
Modified:
3 years, 3 months ago
Reviewers:
yushin
Visibility:
Public.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M examples/encoder_example.c View 3 chunks +3 lines, -5 lines 3 comments Download

Messages

Total messages: 6
tdaede
3 years, 3 months ago #1
yushin
http://review.xiph.org/916/diff/1506/examples/encoder_example.c File examples/encoder_example.c (right): http://review.xiph.org/916/diff/1506/examples/encoder_example.c#newcode354 examples/encoder_example.c:354: } I think we need return 1 here if ...
3 years, 3 months ago #2
tdaede
http://review.xiph.org/916/diff/1506/examples/encoder_example.c File examples/encoder_example.c (right): http://review.xiph.org/916/diff/1506/examples/encoder_example.c#newcode354 examples/encoder_example.c:354: } On 2015/08/25 17:12:22, yushin wrote: > I think ...
3 years, 3 months ago #3
yushin
http://review.xiph.org/916/diff/1506/examples/encoder_example.c File examples/encoder_example.c (right): http://review.xiph.org/916/diff/1506/examples/encoder_example.c#newcode354 examples/encoder_example.c:354: } On 2015/08/25 18:06:08, tdaede wrote: > On 2015/08/25 ...
3 years, 3 months ago #4
tdaede
No, see the return statements at the very beginning of the file.
3 years, 3 months ago #5
tdaede
3 years, 3 months ago #6
Er, function. Line 298 and 299.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld