Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(480036)

Issue 815: Render analyzer frame using cairo

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by tdaede
Modified:
3 years, 1 month ago
Reviewers:
negge, tmatth
Visibility:
Public.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Render analyzer frame using cairo #

Total comments: 18

Patch Set 3 : Render analyzer frame using cairo #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M configure.ac View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M examples/analyzer.cc View 1 2 4 chunks +130 lines, -28 lines 0 comments Download

Messages

Total messages: 10
tdaede
3 years, 5 months ago #1
tmatth
http://review.xiph.org/815/diff/1321/examples/analyzer.cc File examples/analyzer.cc (right): http://review.xiph.org/815/diff/1321/examples/analyzer.cc#newcode507 examples/analyzer.cc:507: v_row=img->planes[2].data; spaces needed around = operator http://review.xiph.org/815/diff/1321/examples/analyzer.cc#newcode516 examples/analyzer.cc:516: for(x=0;x<w;x++){ ...
3 years, 5 months ago #2
tdaede
3 years, 4 months ago #3
tmatth
r=me with style issues addressed http://review.xiph.org/815/diff/1427/examples/analyzer.cc File examples/analyzer.cc (right): http://review.xiph.org/815/diff/1427/examples/analyzer.cc#newcode68 examples/analyzer.cc:68: iplane->data = (unsigned char ...
3 years, 4 months ago #4
tmatth
On 2015/07/28 16:09:27, tmatth wrote: > r=me with style issues addressed and unix Makefile updated.
3 years, 4 months ago #5
tmatth
http://review.xiph.org/815/diff/1427/configure.ac File configure.ac (right): http://review.xiph.org/815/diff/1427/configure.ac#newcode103 configure.ac:103: HAVE_CAIRO=no Is this needed? Doesn't the next PKG_CHECK_MODULES line ...
3 years, 4 months ago #6
negge
r- This breaks the zooming functionality: http://people.xiph.org/~unlord/claire-zoom1.png
3 years, 4 months ago #7
negge
On 2015/07/28 16:44:00, negge wrote: > r- > > This breaks the zooming functionality: > ...
3 years, 4 months ago #8
tmatth
http://review.xiph.org/815/diff/1427/examples/analyzer.cc File examples/analyzer.cc (right): http://review.xiph.org/815/diff/1427/examples/analyzer.cc#newcode633 examples/analyzer.cc:633: *cr = OD_CLAMPI(16,crval,235); Around here is where luma gets ...
3 years, 4 months ago #9
tdaede
3 years, 1 month ago #10

          
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld