Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(480093)

Issue 633: Add Frame Count and Resolution to Analyzer

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by crypt
Modified:
3 years, 8 months ago
Reviewers:
tmatth, negge
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : incorporate comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M examples/analyzer.cc View 1 8 chunks +21 lines, -3 lines 1 comment Download

Messages

Total messages: 1
tmatth
3 years, 8 months ago #1
r- you should use an std::string or a wxString, IMHO.

http://review.xiph.org/633/diff/1032/examples/analyzer.cc
File examples/analyzer.cc (right):

http://review.xiph.org/633/diff/1032/examples/analyzer.cc#newcode232
examples/analyzer.cc:232: char *filename;
this would be much simpler with either a wxString or an std::string, you can
then invoke open() with filename.c_str()
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld