Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(484519)

Issue 368: Updated bd_rate.sh using other interpolation methods.

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by negge
Modified:
3 years, 7 months ago
Reviewers:
tdaede
Visibility:
Public.

Patch Set 1 #

Total comments: 10

Patch Set 2 : Adding Basar's changes #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M Makefile.am View 1 2 chunks +10 lines, -0 lines 0 comments Download
M tools/bd_rate2.sh View 1 1 chunk +52 lines, -0 lines 0 comments Download
M tools/bjontegaard2.c View 1 1 chunk +500 lines, -0 lines 3 comments Download

Messages

Total messages: 6
negge
4 years, 4 months ago #1
gmaxwell
just some non-application-specific review. http://review.xiph.org/368/diff/567/tools/bjontegaard2.c File tools/bjontegaard2.c (right): http://review.xiph.org/368/diff/567/tools/bjontegaard2.c#newcode38 tools/bjontegaard2.c:38: BD_RATE = 1, warning due ...
4 years, 4 months ago #2
bkoc
http://review.xiph.org/368/diff/659/tools/bjontegaard2.c File tools/bjontegaard2.c (right): http://review.xiph.org/368/diff/659/tools/bjontegaard2.c#newcode449 tools/bjontegaard2.c:449: No blank lines. http://review.xiph.org/368/diff/659/tools/bjontegaard2.c#newcode465 tools/bjontegaard2.c:465: fprintf (stderr, "Error parsing ...
4 years, 3 months ago #3
tdaede
4 years ago #4
tdaede
r+, though having compile time switches in the code to change the computation is kind ...
4 years ago #5
tdaede
3 years, 7 months ago #6
So... are you ever going to push this?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld