Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(655611)

Issue 1556: vorbis: avoid invalid free (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by tmatth
Modified:
1 year, 5 months ago
Reviewers:
rillian, ron, tdaede
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : vorbis: avoid invalid free #

Patch Set 3 : vorbis: avoid invalid free #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M lib/info.c View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
tmatth
Fixes https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=881130 More detailed backtrace when building vorbis-tools with ASAN: CFLAGS="-O1 -g -fsanitize=address" ./configure make ...
1 year, 5 months ago #1
tmatth
1 year, 5 months ago #2
tmatth
I believe the regression started at commit: 4b67376da7ded7f16dfebb8a05fb559ac7fbcf55 Author: Monty <xiphmont@xiph.org> Date: Wed Jan 21 ...
1 year, 5 months ago #3
tmatth
Alternately we could just do: if(vi->channels>0)oggpack_writeclear(&opb); but that seems less obvious/explicit, and probably more subject ...
1 year, 5 months ago #4
tmatth
1 year, 5 months ago #5
tdaede
1 year, 5 months ago #6
r+
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld