Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(108549)

Issue 1554: configure: add --disable-crc option (for fuzzing)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 5 days ago by tmatth
Modified:
3 weeks, 5 days ago
Reviewers:
derf
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M configure.ac View 1 chunk +11 lines, -0 lines 1 comment Download
M src/framing.c View 7 chunks +14 lines, -0 lines 1 comment Download

Messages

Total messages: 2
tmatth
3 weeks, 5 days ago #1
derf
3 weeks, 5 days ago #2
http://review.xiph.org/1554/diff/2650/configure.ac
File configure.ac (right):

http://review.xiph.org/1554/diff/2650/configure.ac#newcode155
configure.ac:155: [compile without CRC (useful for fuzzing)])],,
It's kind of unclear what "without CRC" means. I'd phrase this as, "Disable CRC
checks in the demuxer."

http://review.xiph.org/1554/diff/2650/src/framing.c
File src/framing.c (right):

http://review.xiph.org/1554/diff/2650/src/framing.c#newcode728
src/framing.c:728: /* replace the computed checksum with the one actually read
in */
So, putting this in the #ifndef and leaving the call to ogg_page_checksum_set()
outside of it "fixes" the page to have a valid CRC, instead of preserving the
(potentially invalid) CRC in the file. Is that the behavior you intended?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld