Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(278494)

Issue 1551: Improve source/stream terminology consistency (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by derf
Modified:
2 years, 1 month ago
Reviewers:
tdaede
Visibility:
Public.

Description

We inherited the term "source" from vorbisfile's "datasource", but
 were using it interchangeably with stream.
At least one user did not even realize the that the _source
 parameter passed to op_open_callbacks() was the same as the
 _stream parameter taken by those callbacks, which is reasonable
 because we never said so.
Consistently use "stream" instead of "source" in both the
 documentation and the code.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M include/opusfile.h View 9 chunks +27 lines, -23 lines 0 comments Download
M src/internal.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/opusfile.c View 10 chunks +26 lines, -26 lines 0 comments Download

Messages

Total messages: 3
derf
2 years, 1 month ago #1
tdaede
r+
2 years, 1 month ago #2
derf
2 years, 1 month ago #3

RSS Feeds Recent Issues | This issue
This is Rietveld