Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(150766)

Issue 1528: Avoid operations linear in the number of links. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by derf
Modified:
6 months ago
Reviewers:
tdaede
Visibility:
Public.

Description

Just in case some bozo makes a chained stream with 272,389 links
 with 16 samples in each (coded at 16 Mbps, including overheads).
This avoids quadratic behavior for simple straight-through
 playback: we no longer do a linear search on each chain boundary
 or each call to op_pcm_tell().
N seeks with M chains still requires O(N*log(M)) work.

Patch Set 1 #

Patch Set 2 : Avoid operations linear in the number of links. #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/internal.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/opusfile.c View 8 chunks +92 lines, -58 lines 4 comments Download

Messages

Total messages: 6
derf
6 months, 1 week ago #1
derf
6 months, 1 week ago #2
tdaede
r+ http://review.xiph.org/1528/diff/2593/src/opusfile.c File src/opusfile.c (right): http://review.xiph.org/1528/diff/2593/src/opusfile.c#newcode869 src/opusfile.c:869: /*Set pcm_end and end_offset so we can skip ...
6 months ago #3
derf
http://review.xiph.org/1528/diff/2593/src/opusfile.c File src/opusfile.c (right): http://review.xiph.org/1528/diff/2593/src/opusfile.c#newcode869 src/opusfile.c:869: /*Set pcm_end and end_offset so we can skip the ...
6 months ago #4
tdaede
http://review.xiph.org/1528/diff/2593/src/opusfile.c File src/opusfile.c (right): http://review.xiph.org/1528/diff/2593/src/opusfile.c#newcode869 src/opusfile.c:869: /*Set pcm_end and end_offset so we can skip the ...
6 months ago #5
derf
6 months ago #6

RSS Feeds Recent Issues | This issue
This is Rietveld