Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(23717)

Issue 1520: Added extra check in image decoder function to make sure that the passed pointers are not NULL. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 4 weeks ago by dan
Modified:
1 month, 1 week ago
Reviewers:
negge, derf, tdaede
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/decode.c View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 3
dan
2 months, 4 weeks ago #1
derf
http://review.xiph.org/1520/diff/2584/src/decode.c File src/decode.c (right): http://review.xiph.org/1520/diff/2584/src/decode.c#newcode1252 src/decode.c:1252: if (dec == NULL || img == NULL) return ...
2 months, 3 weeks ago #2
dan
2 months, 3 weeks ago #3
On 2017/05/06 22:59:05, derf wrote:
> http://review.xiph.org/1520/diff/2584/src/decode.c
> File src/decode.c (right):
> 
> http://review.xiph.org/1520/diff/2584/src/decode.c#newcode1252
> src/decode.c:1252: if (dec == NULL || img == NULL) return 0;
> Our documentation in include/daala/daaladec.h says we're supposed to return
> OD_EFAULT in this case. I could be persuaded either way which return value is
> better, but the value should match the documentation, so one or the other
needs
> to be changed.

Thanks for your review. I have updated the patch but have accidentally  deleted
my development branch so the a new review has been created for this patch. Sorry
for inconvenience. The updated patch 1525 as issue number.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld