http://review.xiph.org/1520/diff/2584/src/decode.c
File src/decode.c (right):
http://review.xiph.org/1520/diff/2584/src/decode.c#newcode1252
src/decode.c:1252: if (dec == NULL || img == NULL) return 0;
Our documentation in include/daala/daaladec.h says we're supposed to return
OD_EFAULT in this case. I could be persuaded either way which return value is
better, but the value should match the documentation, so one or the other needs
to be changed.
On 2017/05/06 22:59:05, derf wrote:
> http://review.xiph.org/1520/diff/2584/src/decode.c
> File src/decode.c (right):
>
> http://review.xiph.org/1520/diff/2584/src/decode.c#newcode1252
> src/decode.c:1252: if (dec == NULL || img == NULL) return 0;
> Our documentation in include/daala/daaladec.h says we're supposed to return
> OD_EFAULT in this case. I could be persuaded either way which return value is
> better, but the value should match the documentation, so one or the other
needs
> to be changed.
Thanks for your review. I have updated the patch but have accidentally deleted
my development branch so the a new review has been created for this patch. Sorry
for inconvenience. The updated patch 1525 as issue number.
Issue 1520: Added extra check in image decoder function to make sure that the passed pointers are not NULL.
(Closed)
Created 12 months ago by dan
Modified 10 months, 2 weeks ago
Reviewers: negge, derf, tdaede
Base URL:
Comments: 1