Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4237)

Issue 1358: Dithering improvement

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by jm
Modified:
5 months ago
Reviewers:
derf, gmaxwell, mark4o
Visibility:
Public.

Description

Reduces the amount of dithering to just the amount we need. This
also eliminates the need to explicitly track silence, since silence will
now go to zero by itself.

Patch Set 1 #

Total comments: 1

Patch Set 2 : new filters #

Patch Set 3 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/opusdec.c View 1 2 4 chunks +26 lines, -22 lines 0 comments Download

Messages

Total messages: 2
jm
1 year, 1 month ago #1
oz
1 year, 1 month ago #2
Comment-wrapping nit :)

http://review.xiph.org/1358/diff/2280/src/opusdec.c
File src/opusdec.c (right):

http://review.xiph.org/1358/diff/2280/src/opusdec.c#newcode197
src/opusdec.c:197: /* Adds just enough noise to cause signals above -128 dBFS to
dither. Signals below
Should Opus comments and code wrap at 79 chars, for ease of review/diffing?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld