Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(318392)

Issue 1345: Adds a generic adaptation scheme based on the Q15 entropy coder (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by jm
Modified:
3 years, 5 months ago
Reviewers:
derf
Visibility:
Public.

Description

This first version is designed to behave as close as possible to the non-Q15
od_{en,de}code_cdf_adapt() functions.

Patch Set 1 #

Total comments: 6

Patch Set 2 : fixed #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/generic_code.c View 1 1 chunk +34 lines, -0 lines 6 comments Download
M src/generic_code.h View 3 chunks +10 lines, -0 lines 0 comments Download
M src/generic_decoder.c View 1 1 chunk +26 lines, -0 lines 0 comments Download
M src/generic_encoder.c View 1 1 chunk +27 lines, -0 lines 2 comments Download

Messages

Total messages: 5
jm
3 years, 5 months ago #1
derf
http://review.xiph.org/1345/diff/2260/src/generic_code.c File src/generic_code.c (right): http://review.xiph.org/1345/diff/2260/src/generic_code.c#newcode47 src/generic_code.c:47: OD_ASSERT(cdf[n-1] == 32768 - n); Spaces around - in ...
3 years, 5 months ago #2
jm
http://review.xiph.org/1345/diff/2260/src/generic_code.c File src/generic_code.c (right): http://review.xiph.org/1345/diff/2260/src/generic_code.c#newcode47 src/generic_code.c:47: OD_ASSERT(cdf[n-1] == 32768 - n); On 2016/04/15 12:34:42, derf ...
3 years, 5 months ago #3
derf
r=me with nits fixed. http://review.xiph.org/1345/diff/2263/src/generic_code.c File src/generic_code.c (right): http://review.xiph.org/1345/diff/2263/src/generic_code.c#newcode42 src/generic_code.c:42: count on input and output ...
3 years, 5 months ago #4
jm
3 years, 5 months ago #5
http://review.xiph.org/1345/diff/2263/src/generic_code.c
File src/generic_code.c (right):

http://review.xiph.org/1345/diff/2263/src/generic_code.c#newcode42
src/generic_code.c:42: count on input and output (cdf[n - 1]) must be equal to
(32768 - n)
On 2016/04/15 13:08:22, derf wrote:
> This comment is now wrong.

Done.

http://review.xiph.org/1345/diff/2263/src/generic_code.c#newcode49
src/generic_code.c:49: for (i = 0; i < n; i++) cdf[i] -= (i + 1);
On 2016/04/15 13:08:22, derf wrote:
> No parentheses around i + 1.

Done.

http://review.xiph.org/1345/diff/2263/src/generic_code.c#newcode71
src/generic_code.c:71: for (i = 0; i < n; i++) cdf[i] += (i + 1);
On 2016/04/15 13:08:22, derf wrote:
> No parentheses around i + 1.

Done.

http://review.xiph.org/1345/diff/2263/src/generic_encoder.c
File src/generic_encoder.c (right):

http://review.xiph.org/1345/diff/2263/src/generic_encoder.c#newcode52
src/generic_encoder.c:52: /* On the first call, we normalize the cdf to (32768 -
n). This should
On 2016/04/15 13:08:22, derf wrote:
> Also wrong now.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld