Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(549723)

Issue 133: Fix compilation issues on FreeBSD (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by negge
Modified:
5 years, 1 month ago
Reviewers:
derf, ron
Visibility:
Public.

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M ci/autotools.sh View 1 chunk +1 line, -1 line 2 comments Download
M ci/coverage.sh View 1 chunk +1 line, -1 line 0 comments Download
M ci/scan-build.sh View 1 chunk +1 line, -1 line 0 comments Download
M ci/unix.sh View 1 chunk +1 line, -1 line 0 comments Download
M tools/intra_pred.c View 5 chunks +12 lines, -12 lines 3 comments Download
M tools/rd_collect.sh View 1 chunk +1 line, -1 line 0 comments Download
M tools/rd_collect_sub.sh View 1 chunk +1 line, -1 line 0 comments Download
M tools/rd_plot.sh View 1 chunk +1 line, -1 line 0 comments Download
M tools/unix/Makefile View 1 chunk +2 lines, -2 lines 1 comment Download
M unix/Makefile View 1 chunk +2 lines, -1 line 0 comments Download
M update_version View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
derf
http://review.xiph.org/133/diff/195/ci/autotools.sh File ci/autotools.sh (right): http://review.xiph.org/133/diff/195/ci/autotools.sh#newcode1 ci/autotools.sh:1: #!/usr/bin/env bash -e How portable is this to non-BSD ...
5 years, 1 month ago #1
ron
http://review.xiph.org/133/diff/195/ci/autotools.sh File ci/autotools.sh (right): http://review.xiph.org/133/diff/195/ci/autotools.sh#newcode1 ci/autotools.sh:1: #!/usr/bin/env bash -e This one is a bit awkward, ...
5 years, 1 month ago #2
ron
http://review.xiph.org/133/diff/195/tools/unix/Makefile File tools/unix/Makefile (right): http://review.xiph.org/133/diff/195/tools/unix/Makefile#newcode26 tools/unix/Makefile:26: MAKEDEPEND = ${CC} -MM This one should be $(CC) ...
5 years, 1 month ago #3
ron
http://review.xiph.org/133/diff/195/tools/intra_pred.c File tools/intra_pred.c (right): http://review.xiph.org/133/diff/195/tools/intra_pred.c#newcode979 tools/intra_pred.c:979: gettimeofday(&start,NULL); To do this portably we'll need to split ...
5 years, 1 month ago #4
ron
http://review.xiph.org/133/diff/195/tools/intra_pred.c File tools/intra_pred.c (right): http://review.xiph.org/133/diff/195/tools/intra_pred.c#newcode979 tools/intra_pred.c:979: gettimeofday(&start,NULL); On 2014/01/08 17:11:37, ron wrote: > To do ...
5 years, 1 month ago #5
negge
5 years, 1 month ago #6
On 2014/01/08 17:06:27, ron wrote:
> http://review.xiph.org/133/diff/195/tools/unix/Makefile
> File tools/unix/Makefile (right):
> 
> http://review.xiph.org/133/diff/195/tools/unix/Makefile#newcode26
> tools/unix/Makefile:26: MAKEDEPEND = ${CC} -MM
> This one should be $(CC) rather than ${CC}.  And we can probably drop the
> explicit CC ?= cc, since that should be its default in all makes anyhow. 
> There's no guarantee that all cc will have -MM, but that's probably not worse
> than forcing gcc by default.

See https://review.xiph.org/137 for a proposed patch that does just this.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld