Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(377439)

Issue 1235: Free memory if od_dec_init fails.

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 8 months ago by negge
Modified:
3 years, 6 months ago
Reviewers:
derf, tmatth
Visibility:
Public.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/decode.c View 3 chunks +4 lines, -1 line 1 comment Download

Messages

Total messages: 6
negge
3 years, 8 months ago #1
negge
3 years, 8 months ago #2
tmatth
r=me with nit http://review.xiph.org/1235/diff/2070/src/decode.c File src/decode.c (right): http://review.xiph.org/1235/diff/2070/src/decode.c#newcode61 src/decode.c:61: if (ret < 0) return ret; ...
3 years, 8 months ago #3
tmatth
r=me with nit
3 years, 8 months ago #4
derf
On 2016/01/29 12:19:04, tmatth wrote: > r=me with nit Did this land?
3 years, 6 months ago #5
negge
3 years, 6 months ago #6
On 2016/03/25 16:24:05, derf wrote:
> On 2016/01/29 12:19:04, tmatth wrote:
> > r=me with nit
> 
> Did this land?

No it has not landed yet.  When I started going through I noticed that
od_state_init() leaked memory if it failed.  I was going to fix that also.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld