Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(480047)

Issue 1184: Implement opusdec via libopusfile

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by derf
Modified:
2 years, 7 months ago
Reviewers:
tmatth, mark4o
Visibility:
Public.

Description

Implement opusdec via libopusfile

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M man/opusdec.1 View 2 chunks +6 lines, -1 line 0 comments Download
M src/opusdec.c View 10 chunks +516 lines, -475 lines 3 comments Download

Messages

Total messages: 2
tmatth
http://review.xiph.org/1184/diff/1984/src/opusdec.c File src/opusdec.c (right): http://review.xiph.org/1184/diff/1984/src/opusdec.c#newcode1151 src/opusdec.c:1151: if (permuted_output) This conditional isn't needed
2 years, 11 months ago #1
mark4o
2 years, 7 months ago #2
http://review.xiph.org/1184/diff/1984/src/opusdec.c
File src/opusdec.c (right):

http://review.xiph.org/1184/diff/1984/src/opusdec.c#newcode646
src/opusdec.c:646: shapemem, file_output, (nb_read_total*rate/48000)-link_out);
This can overflow with 32 years of audio (@ 192 kHz)

http://review.xiph.org/1184/diff/1984/src/opusdec.c#newcode1101
src/opusdec.c:1101: maxout=(nb_read_total*rate/48000)-link_out;
This can overflow with 32 years of audio (@ 192 kHz)
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld