Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(480034)

Issue 1174: Add test script for i386.

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 11 months ago by kylesiefring
Modified:
2 years, 11 months ago
Reviewers:
tmatth
Visibility:
Public.

Description

Currently fails on master.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add single quotes and -O2 and -g. #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
A ci/i386.sh View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4
tmatth
http://review.xiph.org/1174/diff/1953/ci/i386.sh File ci/i386.sh (right): http://review.xiph.org/1174/diff/1953/ci/i386.sh#newcode10 ci/i386.sh:10: CFLAGS=-m32 ./configure Should have single quotes around -m32 to ...
2 years, 11 months ago #1
tmatth
On 2015/12/23 08:19:51, tmatth wrote: > http://review.xiph.org/1174/diff/1953/ci/i386.sh > File ci/i386.sh (right): > > http://review.xiph.org/1174/diff/1953/ci/i386.sh#newcode10 > ...
2 years, 11 months ago #2
kylesiefring
On 2015/12/23 08:21:24, tmatth wrote: > On 2015/12/23 08:19:51, tmatth wrote: > > http://review.xiph.org/1174/diff/1953/ci/i386.sh > ...
2 years, 11 months ago #3
tmatth
2 years, 11 months ago #4
On 2016/01/14 13:49:53, kylesiefring wrote:
> On 2015/12/23 08:21:24, tmatth wrote:
> > On 2015/12/23 08:19:51, tmatth wrote:
> > > http://review.xiph.org/1174/diff/1953/ci/i386.sh
> > > File ci/i386.sh (right):
> > > 
> > > http://review.xiph.org/1174/diff/1953/ci/i386.sh#newcode10
> > > ci/i386.sh:10: CFLAGS=-m32 ./configure
> > > Should have single quotes around -m32 to be consistent with
ci/autotools.sh
> > 
> > Also, any reason for not include -O2 and -g (like we do in autotools.sh)?
> 
> Got both of these in.

With gcc-4.8.4, I'm getting 

In file included from src/x86/sse2filter.c:35:0:
/usr/lib/gcc/x86_64-linux-gnu/4.8/include/emmintrin.h:31:3: error: #error "SSE2
instruction set not enabled"
 # error "SSE2 instruction set not enabled"

followed by more errors about __mm128i etc.

If I add -msse2 to CFLAGS in the script, I do a bit better (I believe this is
the error you were catching as well?):

src/x86/sse2mc.c:1332:5: error: 'asm' operand has impossible constraints
     __asm__ __volatile__(
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld