Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(480090)

Issue 1068: Add loupe to the analyzer.

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by mbx
Modified:
3 years, 1 month ago
Reviewers:
negge, oz
CC:
mbx
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Hande case where the loupe is outside of the display rect. #

Total comments: 6

Patch Set 3 : Fix style. #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M examples/analyzer.cc View 1 2 10 chunks +50 lines, -1 line 0 comments Download

Messages

Total messages: 3
mbx
3 years, 1 month ago #1
oz
3 long-line nits. I didn't test functionality of code... http://review.xiph.org/1068/diff/1764/examples/analyzer.cc File examples/analyzer.cc (right): http://review.xiph.org/1068/diff/1764/examples/analyzer.cc#newcode1045 examples/analyzer.cc:1045: ...
3 years, 1 month ago #2
mbx
3 years, 1 month ago #3
http://review.xiph.org/1068/diff/1764/examples/analyzer.cc
File examples/analyzer.cc (right):

http://review.xiph.org/1068/diff/1764/examples/analyzer.cc#newcode1045
examples/analyzer.cc:1045: wxRect loupeRect(col - loupeRadius, row -
loupeRadius, loupeRadius*2, loupeRadius*2);
On 2015/11/02 08:37:46, oz wrote:
> Wrap long lines at 79 chars please :)

Done.

http://review.xiph.org/1068/diff/1764/examples/analyzer.cc#newcode1046
examples/analyzer.cc:1046: /* The loupe may be partially outside of the display
rect, thus we need to clip the
On 2015/11/02 08:37:46, oz wrote:
> Long line.

Done.

http://review.xiph.org/1068/diff/1764/examples/analyzer.cc#newcode1052
examples/analyzer.cc:1052: wxImage loupeImg =
img.GetSubImage(loupeRect).Scale(loupeRect.GetWidth()*loupeZoom,
On 2015/11/02 08:37:46, oz wrote:
> Long line.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld