Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(484542)

Issue 1054: Updates plane when 'P' is pressed in real-time

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by MeNowDeal
Modified:
3 years, 1 month ago
Reviewers:
negge, mbx
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Add real-time changing of layer when paused #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M examples/player_example.c View 1 8 chunks +11 lines, -7 lines 3 comments Download

Messages

Total messages: 2
MeNowDeal
3 years, 1 month ago #1
mbx
3 years, 1 month ago #2
Pressing p after pausing causes the player to advance 1 frame before updating
the layer. Subsequent presses don't advance frames.

http://review.xiph.org/1054/diff/1748/examples/player_example.c
File examples/player_example.c (right):

http://review.xiph.org/1054/diff/1748/examples/player_example.c#newcode98
examples/player_example.c:98: void player_refresh(player_example *player);
Looks like all other functions are called player_example_... so this should
probably be renamed.

http://review.xiph.org/1054/diff/1748/examples/player_example.c#newcode140
examples/player_example.c:140: player->loop = 1;
Please submit different patches for unrelated changes.

http://review.xiph.org/1054/diff/1748/examples/player_example.c#newcode257
examples/player_example.c:257: if(player->paused)
Style nit, space after if.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld